Closed
Conversation
Member
|
The next beta of webpack should have a fix to its es2015 module support which should hopefully remove the need to use the UMD bundles. So it would probably be best to leave the version as-is until the next webpack release. |
Contributor
|
#2011 pushed to beta.22 which fixed the bundle hack. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
clydin
pushed a commit
to clydin/angular-cli
that referenced
this pull request
Aug 29, 2023
critters is shipped with ES2015 this that we cannot extend it when we use the UMD because a downlevelled class cannot extend an ES2015 class as it will cause `cannot be invoked without 'new'` With this change, critters will be included in the UMD bundle and downelevelled which would result in us being able to extend it. Closes angular#1970
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.