feat(module): add ability to generate a routing file for new modules#1971
feat(module): add ability to generate a routing file for new modules#1971Brocco merged 1 commit intoangular:masterfrom
Conversation
|
LGTM, but I'll block this until my e2e is in and you add a new e2e to test this. It's easy so shouldn't be a big deal ;) |
|
Okay my e2e PR is in master now. Could you rebase and add an e2e? It should be simple :) Just add a new e2e for modules (I think there might be missing one already). |
Brocco
force-pushed
the
module-routes
branch
from
55d7d81 to
7f41ead
Compare
|
@hansl I updated the PR with some e2e tests |
|
|
||
|
|
||
| export default function() { | ||
| const moduleDir = join(process.cwd(), 'src', 'app', 'test-module'); |
There was a problem hiding this comment.
avoid using process.cwd(). And you can simply use src/app/test-module as it doesn't matter if it's windows or not (for the expect functions).
Brocco
force-pushed
the
module-routes
branch
from
7f41ead to
921ea84
Compare
|
LGTM |
|
Does this enable route generation or it is still disabled? |
|
It generates all the building block but not route generation. Inserting and making your routes is simpler now than it was before though. |
|
Thanks you! |
|
@hansl, re
It looks like this is included in the latest release but how do we use it? |
|
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.