fix(find-lazy-modules): JSON parse error for loadChildren#1972
fix(find-lazy-modules): JSON parse error for loadChildren#1972chalin wants to merge 1 commit intoangular:masterfrom
Conversation
|
Nice find |
|
LGTM but @hansl can you weigh in? |
|
This fix is faulty though since it replaces quotes regardless of context. I think I know what's going on, might take a look at it tomorrow. Might just need to evaluate the code (or even better don't parse JSON since we shouldn't need to). |
|
I already made a function to get the string value of the key of an object, the more I think about that line the clearer the fix is. Typescript gives us the string value of a string literal, I just need to use that. My bad for this horrible code in the first place. I was young, and that was folly. |
and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes angular#1891, angular#1960. cc @filipesilva @ericjim @chalin - See similar angular#1972
and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes angular#1891, angular#1960. cc @filipesilva @ericjim @chalin - See similar angular#1972
|
Closed in favor of #1987 |
) * fix(find-lazy-modules): Allow for any valid keys/value to be used and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes #1891, #1960. cc @filipesilva @ericjim @chalin - See similar #1972 * cleanup
…gular#1987) * fix(find-lazy-modules): Allow for any valid keys/value to be used and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes angular#1891, angular#1960. cc @filipesilva @ericjim @chalin - See similar angular#1972 * cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Fixes #1891, #1960.
cc @filipesilva @ericjim - was failing for ng2.io, but this fixes the issue.