feat(new command): override the initial commit message#20
Closed
cironunes wants to merge 1 commit intoangular:masterfrom
Closed
feat(new command): override the initial commit message#20cironunes wants to merge 1 commit intoangular:masterfrom
cironunes wants to merge 1 commit intoangular:masterfrom
Conversation
Member
Author
There was a problem hiding this comment.
I didn't get any original idea to put in here 😢
cironunes
force-pushed
the
initial-commit
branch
from
c7b793e to
3abb87c
Compare
addon/ng2/commands/new.js
Outdated
Contributor
There was a problem hiding this comment.
Let's change ember to ng so we don't forget it later.
cironunes
force-pushed
the
initial-commit
branch
from
3abb87c to
6d714f2
Compare
Contributor
|
The remaining issues with the PR are nice to haves, so I'll merge this and open new issues to keep track of them. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can see, I needed to duplicate a lot of code just to override some properties. It would be nice to fix it in ember-cli.
Closes #19