fix(init): fix link and npm install#2086
Conversation
filipesilva
force-pushed
the
fix-link-cli
branch
from
122b950 to
d64a7ef
Compare
| if (err) { | ||
| ui.writeLine(stderr); | ||
| ui.writeLine(chalk.red('Package install failed, see above.')); | ||
| exitCode = 1; |
There was a problem hiding this comment.
Any reason you're not rejecting the promise?
There was a problem hiding this comment.
Copy paste from e2e... which means that one is also broken.
There was a problem hiding this comment.
Fixed here but not the e2e. I assume it needs further changes and don't wanna mix the two things up.
filipesilva
force-pushed
the
fix-link-cli
branch
12 times, most recently
from
316aacf to
f9b1863
Compare
|
Lgtm |
|
This is already merged and needs no further look, but I just wanted to say, congratulations and thank you for moving away from the extra local install of in PM. That is a nice initial step toward paring back the dependency count and size. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Currently,
ng new proj --link-clibreaks the linkedangular-cliinstall due to npm/npm#10343.This PR changes our
initprocess to link after install, which takes longer but doesn't break dependencies. It also does not use localnpmand instead uses the globalnpmsince it's what we already use for other commands./cc @hansl