fix: check for old version of the CLI on empty project

[ValeryVS]

On empty project, when config files are not exists CliConfig.configFilePath will return null.
null is not valid argument for readFileSync
There was TypeError: path must be a string or Buffer
#2135

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[ValeryVS]

I signed it!

[googlebot]

CLAs look good, thanks!

[ValeryVS]

This error was with node 6.5.0

[BenoitFroment]

just updated to node 6.6.0, same errors

[filipesilva]

Putting this PR on hold until we can figure out what's happening in #2135.

[ValeryVS]

When there is no angular-cli.json
at this line
https://github.com/ValeryVS/angular-cli/blob/65393147df665f45ebe835a10a3de4c68728d324/packages/angular-cli/upgrade/version.ts#L78
configPath will be null, because CliConfig.configFilePath() will retun null

angular-cli/packages/angular-cli/models/config.ts

Line 32 in 21003b1

static configFilePath(projectPath?: string): string {

using _findup function

angular-cli/packages/angular-cli/models/config.ts

Line 22 in 21003b1

return null;

[GabrielDumbrava]

Can you please merge this PR. It's really annoying to not be able to use the new command. If I create the missing angular-cli.json file as a workaround I get the error:
You cannot use the new command inside an angular-cli project.

[ValeryVS]

Rebased to master

[filipesilva]

@ValeryVS thanks for the explanation and fix for this issue. Can you add a test to ensure we don't run into it again?

You can add it in tests/e2e/tests/misc/version.ts. It seems to be enough to delete angular-cli.json and run ng version to reproduce the problem, so that should be enough to do in the test to make sure your fix works.

[miuel]

Thanks @ValeryVS to solve it !

[filipesilva]

I amended your commit with said test and pushed it to master. Thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}