fix(generate): use prefix when initializing app (#2046)#2367
Merged
hansl merged 1 commit intoangular:masterfrom Sep 28, 2016
Gelio:app-prefix-fix
Merged
fix(generate): use prefix when initializing app (#2046)#2367hansl merged 1 commit intoangular:masterfrom Gelio:app-prefix-fix
hansl merged 1 commit intoangular:masterfrom
Gelio:app-prefix-fix
Conversation
E2E test would fail when using a prefix to generate the app
Contributor
|
LGTM. Thanks! |
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 2, 2016
…ar#2367) E2E test would fail when using a prefix to generate the app
deebloo
pushed a commit
to deebloo/angular-cli
that referenced
this pull request
Oct 3, 2016
…ar#2367) E2E test would fail when using a prefix to generate the app
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E test would fail when using a prefix to generate the app.
I've updated the initial component generator to take prefix into account.
Fixes issue #2046