chore(tests): Auto run tests after builds#237
Conversation
e3b32c5 to
52ccba5
Compare
addon/ng2/commands/build.js
Outdated
|
|
||
| availableOptions: [ | ||
| { name: 'environment', type: String, default: 'development', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }] }, | ||
| { name: 'output-path', type: path, default: 'dist/', aliases: ['o'] }, |
There was a problem hiding this comment.
Is it a good idea to allow customizing the output path? Commands like test expect stuff to be in dist/ and will break if that changes.
There was a problem hiding this comment.
You are correct, this is a holdover from pulling in the ember-cli build command.
|
The cli e2e test suite should also be changed I believe, otherwise tests will run twice (once on |
|
There will be no conflict here, nothing in the build command task chain will call the e2e command or task. |
|
I mean in this file, when you run tests after running build: |
52ccba5 to
912dfb9
Compare
When running `ng build` or `ng build --watch` karma tests are run after builds `--no-test` swtich to turn it off
912dfb9 to
2ea6b3d
Compare
|
Closing... in favor of adding watch mode to the test command |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When running
ng buildorng build --watchkarma tests are run after builds--no-testswtich to turn it off