fix(generate): make generated component.spec consistent with AppCompo…

[lacolaco]

…nent spec

ng new generates a little rich spec file for AppComponent

/* tslint:disable:no-unused-variable */

import { TestBed, async } from '@angular/core/testing';
import { AppComponent } from './app.component';

describe('App: test-app', () => {
  beforeEach(() => {
    TestBed.configureTestingModule({
      declarations: [
        AppComponent
      ],
    });
  });

  it('should create the app', async(() => {
    let fixture = TestBed.createComponent(AppComponent);
    let app = fixture.debugElement.componentInstance;
    expect(app).toBeTruthy();
  }));

  it(`should have as title 'app works!'`, async(() => {
    let fixture = TestBed.createComponent(AppComponent);
    let app = fixture.debugElement.componentInstance;
    expect(app.title).toEqual('app works!');
  }));

  it('should render title in a h1 tag', async(() => {
    let fixture = TestBed.createComponent(AppComponent);
    fixture.detectChanges();
    let compiled = fixture.debugElement.nativeElement;
    expect(compiled.querySelector('h1').textContent).toContain('app works!');
  }));
});

But a spec via ng generate component is not so. Imperative component instantiation is not a good pattern, I think.

/* tslint:disable:no-unused-variable */

import { TestBed, async } from '@angular/core/testing';
import { HeroDetailComponent } from './hero-detail.component';

describe('Component: HeroDetail', () => {
  it('should create an instance', () => {
    let component = new HeroDetailComponent();
    expect(component).toBeTruthy();
  });
});

At least, I think it should generate a spec using TestBed.

[filipesilva]

We actually made it this basic (#1085) in response to user feedback that it was too complicated.

That was a different time though, when TestBed didn't exist. @Brocco do you think we should add it in?

[Brocco]

I actually prefer this change. Yes, we did simplify, but as @filipesilva pointed out, that was before TestBed was implemented.

This PR adds the suggested test strategy without adding complication or bloat of spec files.

It has my approval, but I won't merge until others have a chance to weigh in. I would like to have teh opinion of @wardbell on this one, because he is passionate about testing and was involved in the spec simplification change.

[wardbell]

I think there is more of a case for generating a true Component spec, now that the TestBed is so sweet.

However, this isn't that spec. Rather than go on at length about what's amiss with this one, @Brocco, should we use it for inspiration and work up something on the side? You know how to reach me.

[Brocco]

Closing... handled via PR #2674

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}