feat(build): add gzip to serve --prod#2621
Closed
filipesilva wants to merge 3 commits intoangular:masterfrom
Closed
feat(build): add gzip to serve --prod#2621filipesilva wants to merge 3 commits intoangular:masterfrom
filipesilva wants to merge 3 commits intoangular:masterfrom
Conversation
Contributor
|
Wouldn't it be a better idea to support the --compress argument to make this optional instead of forcing gzip in prod? |
Contributor
Author
|
@grizzm0 we don't offer a lot of customization on the set of transformations so I don't see when the use of compression should be a decision point (or why it should be while others aren't). |
Brocco
approved these changes
Oct 14, 2016
Brocco
pushed a commit
that referenced
this pull request
Oct 19, 2016
kieronqtran
pushed a commit
to kieronqtran/angular-cli
that referenced
this pull request
Oct 21, 2016
texel
pushed a commit
to splice/angular-cli
that referenced
this pull request
Nov 3, 2016
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2028