(fix) ng complete: Suggest different way to capture output to .bashrc/.zshrc#2635
Closed
catull wants to merge 4 commits intoangular:masterfrom
Closed
(fix) ng complete: Suggest different way to capture output to .bashrc/.zshrc#2635catull wants to merge 4 commits intoangular:masterfrom
ng complete: Suggest different way to capture output to .bashrc/.zshrc#2635catull wants to merge 4 commits intoangular:masterfrom
Conversation
filipesilva
suggested changes
Oct 10, 2016
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
Can you also update the readme to reflect this?
catull
commented
Oct 10, 2016
Contributor
Author
catull
left a comment
catull
left a comment
There was a problem hiding this comment.
You are right, the fix MUST not be hidden in the script file; only a handful of people know where to look. Will document the suggested fix in README.md.
…fix-suggest-different-shell-output-redirection' of github.com:catull/angular-cli into fix-suggest-different-shell-output-redirection
Contributor
Author
|
Complied with the review finding. |
filipesilva
approved these changes
Oct 10, 2016
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 14, 2016
Brocco
pushed a commit
that referenced
this pull request
Oct 19, 2016
texel
pushed a commit
to splice/angular-cli
that referenced
this pull request
Nov 3, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At long last, the output of
ng completioncan all be fed to your favourite shell startup file.The discussion took place in issue #2253, the reasoning behind this PR is at #2253 (comment).