Fix Protractor test so 'ng e2e' succeeds after 'ng new'#271
Fix Protractor test so 'ng e2e' succeeds after 'ng new'#271jkuri merged 1 commit intoangular:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
This seems to be that the matcher is using CamelCase of the AppName, rather than the kebab-case. Have you tried using I would side on safety here and use the proper selector 😄 |
|
Yeah it should be Good catch @mraible! |
|
I changed it to |
|
lgtm |
|
Please squash this two commits into one. If you need a help doing that just say. |
|
@jkuri - I found an answer on Stack Overflow on how to do it, but I'm not sure of the command. Is it something like this? |
And please rename the commit to something like Thanks. |
1c8432b to
17cb4da
Compare
|
@jkuri Thanks for the assistance. |
|
@mraible np, thank you for the fix. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix Protractor test so
ng e2esucceeds afterng new.