bug(test): Logs errors in module loading in ng2's test.ts#2785
Closed
renehamburger wants to merge 1 commit intoangular:masterfrom
Closed
bug(test): Logs errors in module loading in ng2's test.ts#2785renehamburger wants to merge 1 commit intoangular:masterfrom
renehamburger wants to merge 1 commit intoangular:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
943839a to
a4d52be
Compare
a4d52be to
1bb49f5
Compare
Contributor
|
Got it! I reproed and saw how your changes help. We'll merge it in soon, thanks! |
filipesilva
approved these changes
Oct 23, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2640
@filipesilva, if you run
ng testin https://github.com/renehamburger/angular-cli-issue/commits/master at HEAD and HEAD^ you'll be able to see the difference the logging of the exception makes.