fix(serve): rebuilds after new typings are installed#295
Closed
jkuri wants to merge 1 commit intoangular:masterfrom
Closed
fix(serve): rebuilds after new typings are installed#295jkuri wants to merge 1 commit intoangular:masterfrom
jkuri wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
I assume this PR is going on top of PR#294? |
Contributor
Author
|
Yes. Should I include it in #294? |
| outputFile: '/thirdparty/libs.js', | ||
| allowNone: true | ||
| var typingsTree = new Funnel('typings', { | ||
| exclude: ['**/*.d.ts'] |
Contributor
There was a problem hiding this comment.
What does this tree include? typings should only contain .d.ts files.
Contributor
Author
There was a problem hiding this comment.
Its checking typings directory for changes but does not copy .d.ts files.
Contributor
|
LGTM, please update and commit. |
Contributor
|
There might be some overlap between this PR and #306 |
Contributor
Author
|
Yes, closing this. |
Contributor
Author
clydin
pushed a commit
that referenced
this pull request
Jun 5, 2018
hansl
pushed a commit
that referenced
this pull request
Jun 6, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.