fix(ng2 blueprint): register provider on root component#302
Merged
jkuri merged 1 commit intoangular:masterfrom Mar 17, 2016
Merged
fix(ng2 blueprint): register provider on root component#302jkuri merged 1 commit intoangular:masterfrom
jkuri merged 1 commit intoangular:masterfrom
Conversation
Member
|
@cburgdorf can you please rebase against the current master? |
It's best practice to configure providers on the root component rather than with bootstrap.
cburgdorf
force-pushed
the
fix_providers
branch
from
bd0107c to
7be364b
Compare
Contributor
Author
|
@cironunes done |
Contributor
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301