fix(build) use custom index value when copying to 404.html during github deploy#3201
Merged
hansl merged 2 commits intoangular:masterfrom Nov 23, 2016
Merged
fix(build) use custom index value when copying to 404.html during github deploy#3201hansl merged 2 commits intoangular:masterfrom
hansl merged 2 commits intoangular:masterfrom
Conversation
related to fix in angular#2767 There is no guarantee that there will be an `index.html` file, as the developer may specify a custom index file. When a developer uses a custom index file, use that file name when copying to the 404.html file.
AnalogJ
changed the title
fix incorrect `this` refernce.
AnalogJ
added a commit
to AnalogJ/capsulecd-web-v2
that referenced
this pull request
Nov 20, 2016
…okie). Storing service_type inside localStorage. Using my branch of angular-cli until angular/angular-cli#3201 is merged.
Contributor
|
LGTM. Thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to fix in #2767
There is no guarantee that there will be an
index.htmlfile, as the developer may specify a custom index file.When a developer uses a custom index file, use that file name when copying to the 404.html file.