feat(builder): broccoli bump to 1.0 by hansl · Pull Request #332 · angular/angular-cli

hansl · 2016-03-21T02:40:19Z

This is the right PR for the broccoli upgrade.

Original was #299.

googlebot · 2016-03-21T02:40:21Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

jkuri · 2016-03-21T02:41:51Z

Cool! I will close mine PR but leave local branch if you find anything useful.

filipesilva · 2016-03-22T13:45:35Z

I went over the changes and it lgtm. Also checked the CI logs and couldn't find any weird stuff.

filipesilva · 2016-03-22T14:16:12Z

Setting "compileOnSave": false, on tsconfig.json makes every save break on my IDE (Atom).

I thought it might be a sign that there's something wrong with manual compilation. Compiling with tsc -p works, but compiling directly from the src dir does not.

filipe.silva@DESKTOP-7ND6T3R MINGW64 /E/dev/ideablade/testing/testproj2 (master)
$ tsc -p src/

filipe.silva@DESKTOP-7ND6T3R MINGW64 /E/dev/ideablade/testing/testproj2 (master)
$ cd src/

filipe.silva@DESKTOP-7ND6T3R MINGW64 /E/dev/ideablade/testing/testproj2/src (master)
$ tsc
app.ts(1,25): error TS2307: Cannot find module 'angular2/platform/browser'.
app/testproj2.ts(1,25): error TS2307: Cannot find module 'angular2/core'.
app/testproj2.ts(2,64): error TS2307: Cannot find module 'angular2/router'.

filipesilva · 2016-03-22T14:23:05Z

Running ng build will generate .js and .js.map files inside src/app. @jkuri and I were able to reproduce this.

jkuri · 2016-03-22T14:24:48Z

lib/broccoli/broccoli-typescript.js

+ * re-emitted. This primarily affects code that uses `const enum`s, because changing the enum value
+ * requires global emit, which can affect many files.
+ */
+class DiffingTSCompiler extends Plugin {


hansl · 2016-03-22T15:26:17Z

@filipesilva I fixed the bug where js and js.map were generated in the source directory. Everything should be fine now.

filipesilva · 2016-03-22T15:30:58Z

Tested and can confirm it's fixed.

jkuri · 2016-03-22T15:39:59Z

lib/broccoli/angular2-app.js

-        }));
+    // Add all spec files to files. We need this because spec files are their own entry
+    // point.
+    fs.readdirSync(sourceDir).forEach(function addPathRecursive(name) {


jkuri · 2016-03-22T15:40:44Z

lib/broccoli/angular2-app.js

      this.index(),
      vendorNpmTree,
-      thirdPartyJs
+      thirdPartyJs,


can you remove this please, we are not using it anymore?

hansl · 2016-03-22T15:47:13Z

Also added a test to make sure ng build doesn't change anything in git.

jkuri · 2016-03-22T15:50:15Z

I still need to bug a bit, unfortunately there is still issue when some .ts file changes;
file changed app/proj1.ts ENOENT: no such file or directory, scandir '/Users/jan/Desktop/angular-cli/proj1/tmp/funnel-input_base_path-tOrNtqOJ.tmp/0/src/'
After this will be solved it is ready for merge, I will help you check it.

Btw, you increased performance by 1/3 👍

jkuri · 2016-03-22T16:40:16Z

I cannot comment on the lines that are not being changed so I will write fixes here;

in broccoli-typescript.js:115 add o.name = path.join(_this.outputPath, o.name);
in service-worker-manifest.js:40 replace with var manifestPath = path.join(this.cachePath, MANIFEST_FILE)

Please let me know when you will be done so I can check it.

hansl · 2016-03-22T19:22:08Z

Fixed what I think were all bugs. Please take another look.

@alxhub: could you take a look at the SWManifest? I stopped reading the manifest file and instead keep the hash in memory.

jkuri · 2016-03-22T20:21:17Z

LGTM

angular-automatic-lock-bot · 2019-09-09T22:41:17Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

hansl mentioned this pull request Mar 21, 2016

feat(builder): broccoli bump to 1.0 #299

Closed

hansl added cla: yes state: WIP labels Mar 21, 2016

feat(builder): broccoli bump to 1.0

cae1370

hansl force-pushed the broccoli1 branch 6 times, most recently from 85414a2 to 3e4a470 Compare March 22, 2016 05:25

hansl added pr_action: review and removed state: WIP labels Mar 22, 2016

hansl force-pushed the broccoli1 branch from 3e4a470 to 7ecee1a Compare March 22, 2016 05:39

filipesilva added pr_state: LGTM and removed pr_action: review labels Mar 22, 2016

filipesilva added pr_action: review and removed pr_state: LGTM labels Mar 22, 2016

jkuri reviewed Mar 22, 2016
View reviewed changes

hansl force-pushed the broccoli1 branch from 7ecee1a to 13d4e5f Compare March 22, 2016 15:25

filipesilva added pr_state: LGTM and removed pr_action: review labels Mar 22, 2016

jkuri reviewed Mar 22, 2016
View reviewed changes

hansl force-pushed the broccoli1 branch 3 times, most recently from 2925f7a to 9cc3633 Compare March 22, 2016 15:46

build: Update the broccoli scripts to 1.0

1819afe

hansl force-pushed the broccoli1 branch from 9cc3633 to 1819afe Compare March 22, 2016 19:02

hansl merged commit 1819afe into master Mar 23, 2016

hansl deleted the broccoli1 branch March 23, 2016 01:16

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Conversation

hansl commented Mar 21, 2016

Uh oh!

googlebot commented Mar 21, 2016

Uh oh!

jkuri commented Mar 21, 2016

Uh oh!

filipesilva commented Mar 22, 2016

Uh oh!

filipesilva commented Mar 22, 2016

Uh oh!

filipesilva commented Mar 22, 2016

Uh oh!

jkuri Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

hansl commented Mar 22, 2016

Uh oh!

filipesilva commented Mar 22, 2016

Uh oh!

jkuri Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

jkuri Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

hansl Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

hansl commented Mar 22, 2016

Uh oh!

jkuri commented Mar 22, 2016

Uh oh!

jkuri commented Mar 22, 2016

Uh oh!

hansl commented Mar 22, 2016

Uh oh!

jkuri commented Mar 22, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants