fix(tests): add global scripts in karma plugin

[filipesilva]

Note: renamed and lazy global scripts are not supported.

Fix #2897

[filipesilva]

@YonatanKra can you also review this approach, and confirm it works for your scenario?

I opted to add these changes in the karma plugin to ensure that karma can be ran separately from the ng test command.

[Meligy]

A similar approach would work for serving assets too, right?

[hansl]

config.files.unshift(...globalScriptsPatterns) is simpler.

[filipesilva]

We can't do that in the karma plugin since it's not preprocessed and node4 does not support the spread operator (without a flag).

I hope to tackle that in #3605 by making the plugin be in TypeScript.

[hansl]

Sounds good.

[filipesilva]

@Meligy I had to remove your test setup code because I couldn't have tests afterwards without manually cleaning up the previous ones:

return Promise.resolve()		
    .then(() => testWatchFalseAndSingleRun())		
    .then(() => testAssetsAreServed());

Our test scripts already reset code to it's initial state after each test so it's better to have one file for each test.

[Meligy]

That's perfect. I didn't want to change / introduce file convention in previous commit, but the current way in this PR is super awesome.

[hansl]

LGTM. Cheers!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}