fix(build): hashes in prod builds now changes when ID change.#3609
fix(build): hashes in prod builds now changes when ID change.#3609hansl merged 5 commits intoangular:masterfrom
Conversation
hansl
force-pushed
the
version-router
branch
3 times, most recently
from
3e6be90 to
521e4e7
Compare
tests/e2e/tests/build/chunk-hash.ts
Outdated
| .then(() => { | ||
| fs.readdirSync('./dist') | ||
| .forEach(name => { | ||
| if (!name.match(/(main|inline|style|\d+)\.[a-z0-9]+\.bundle\.js/)) { |
There was a problem hiding this comment.
The styles bundle should be dist/styles.[hash].bundle.css instead of dist/style.[hash].bundle.js.
|
lgtm aside from the styles check. |
hansl
force-pushed
the
version-router
branch
from
521e4e7 to
f3f535f
Compare
|
Amazing!!! |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
hansl
force-pushed
the
version-router
branch
from
3038b79 to
e2e8d2d
Compare
|
CLAs look good, thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Fixes #2868.
Fixes #3311.