Conversation
|
Interesting, I was thinking of having documentation show right in the console, hadn't considered launching a browser. That being said, I like the simplicity of this. |
|
@Brocco; the end goal is to also have a man page for documentation. As of right now, documentation for ng2 is still being built so launching a browser is the second best we can do :) |
|
The only thing to point out is that maybe these new files could be in TS, otherwise both the design and implementation lgtm. |
addon/ng2/commands/doc.js
Outdated
| @@ -0,0 +1,25 @@ | |||
| /* jshint node: true */ | |||
There was a problem hiding this comment.
Could you make this a .ts file? We support TypeScript in angular-cli. After that you can remove the use strict below as all ts files are strict.
|
@hansl of course this makes an excellent solution until we can get in-console docs @filipesilva I agree w/ the idea of making these |
addon/ng2/tasks/doc.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| /* jshint node: true */ | |||
There was a problem hiding this comment.
Same as the command above, please make this a .ts file.
|
2 nits, but LGTM overall. Good work. |
|
Thanks! |
|
Good work Shai! Not sure why Appveyor has started failing. 🤷 LGTM. Do you have permission to merge? If so, you want to If you don't have the proper permissions I can merge for you. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
see #324