Conversation
lib/broccoli/angular2-app.js
Outdated
| destDir: 'vendor' | ||
| }); | ||
|
|
||
| var publicDirTree = new Funnel(path.join(sourceDir, 'public'), { |
There was a problem hiding this comment.
Actually this isn't in sourceDir, it should be on the root itself, no?
There was a problem hiding this comment.
Ah, it was my understanding it would be pulled from src and moved to dist. The issue wasn't very detailed though, so that was my fault for not asking.
There was a problem hiding this comment.
Just to clarify, you'd prefer the public directory to live in the project root, then be moved to dist from there, yes? Or are we skipping all that and just adding the public folder in the root with a .gitignore to force git to recognize it.
There was a problem hiding this comment.
My bad, I talked to the current owner of this feature so we knew :)
I would like to move the content of the public folder inside the dist, yes. Not make a dist/public, but rather have public/**/* copied to dist/**/*.
There was a problem hiding this comment.
Ok, makes more sense now. But just so I'm clear, where do you want public to live? :) In the root or src?
There was a problem hiding this comment.
In the root. It's not sources, it's assets :)
There was a problem hiding this comment.
Ok, that makes more sense now. Appreciate it!
|
This is looking great! If you could just squash all your commits into one (if you need help we can help you) and then I'll merge that commit. Good work 👍 |
hansl
added
pr_action: cleanup
feature
cwramsey
force-pushed
the
adding-public-folder
branch
from
f9a6b1d to
f4f5464
Compare
|
Thanks @hansl! I just rebased everything into a single commit for ya. |
|
You should also clear the Merge commit ;) |
cwramsey
force-pushed
the
adding-public-folder
branch
from
7779adc to
396e662
Compare
cwramsey
force-pushed
the
adding-public-folder
branch
from
396e662 to
ebe438d
Compare
|
@cwramsey Seems like you did something wrong... you'll need to rebase on top of master that's in the original repo (upstream). If you have time I can hop on gitter to help, or if you know what's going on I'll let you fix it :) I can also just fix it in a separate branch and close this PR. Your name will be on the commit. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
I'm fine with you shoving it into a separate branch. My git skills are lacking after a very short night of sleeping last night. That's what I get for trying out github's new |
cwramsey
force-pushed
the
adding-public-folder
branch
from
90752c9 to
da221b7
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Re: #322
This adds a Broccoli funnel that will create a
publicfolder indistthat contains only a.gitignoreon build.This is verified with a test added in
e2e_workflow.spec.js