feat(deploy): add github pages deploy#366
Conversation
e10a411 to
9977e26
Compare
| import * as win from 'ember-cli/lib/utilities/windows-admin'; | ||
| import * as CreateGithubRepo from '../tasks/create-github-repo' | ||
|
|
||
| // import * as https from 'https'; |
There was a problem hiding this comment.
Please remove commented code.
There was a problem hiding this comment.
Ugh.. my bad. Done.
|
For testing, verify if you can monkey patch exec like this: |
package.json
Outdated
| "ember-cli": "2.4.2", | ||
| "exit": "^0.1.2", | ||
| "fs-extra": "^0.26.6", | ||
| "inquirer": "^0.10.1", |
There was a problem hiding this comment.
inquirer comes with ember-cli, we don't need another package.
There was a problem hiding this comment.
FYI you can use it as return this.ui.prompt({ ...
There was a problem hiding this comment.
Did not know that! Using it now.
1625317 to
9a4636d
Compare
|
Fixed the issues pointed out in the comments, looking at tests now. |
|
@filipesilva: ping. What's the status about testing this? |
|
@hansl been working on tests yesterday and today. Expect to have a good few tests by the end of tomorrow. Was a bit tricky since I had to stub I plan to put this out as a helper for other tests to use. |
9a4636d to
59cdc5d
Compare
|
@hansl tests are in. |
6b29d29 to
13d9c91
Compare
| You can modify the these scripts in `package.json` to run whatever tool you prefer. | ||
|
|
||
|
|
||
| ### Formatting code |
There was a problem hiding this comment.
Kinda piggybacking on this PR tbh... but I noticed this is outdated as the previous section covers it. Can put it on a different PR if needed.
fa94de0 to
69dd00d
Compare
|
LGTM. |
69dd00d to
4ba94d9
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR adds (and improves upon) the functionality previously in https://github.com/IgorMinar/angular-cli-github-pages directly to the CLI.
Later, this functionality will be split into an addon of it's own again, but for now it is better to keep it in the same codebase for rapid development.