feature: New command 'set' and 'get' to play with the cli config.#407
feature: New command 'set' and 'get' to play with the cli config.#407hansl merged 1 commit intoangular:masterfrom
Conversation
docs/design/ngConfig.md
Outdated
| * Where in my directory is my karma.conf file? | ||
| * What is my firebase database URL? | ||
| * Where is my client code? | ||
| * How can I use a different |
There was a problem hiding this comment.
I think you forgot something after 'a different'.
|
Can you add a few tests? |
|
This is a Proof of Concept, @jkuri will do the real code. This is just to get him started :) |
| description: 'Set a value in the configuration.', | ||
| works: 'outsideProject', | ||
|
|
||
| availableOptions: [], |
There was a problem hiding this comment.
Shouldn't there be a global option ?
|
|
||
| ## CLI | ||
|
|
||
| #### Getting values |
There was a problem hiding this comment.
When getting values from within the CLI the options object should be exposed via the already existing project object. This will have the benefit of not having to require/import in the configuration object from many different places within the CLI. From commands/tasks/generate blueprints, I would like to see the ability to do the following:
var mySetting = this.project.ng.mySetting
Includes design doc.
|
@hansl whats the status of this PR, is this still a work in progress? |
| }); | ||
|
|
||
| module.exports = SetCommand; | ||
| module.exports.overrideCore = true; |
There was a problem hiding this comment.
You don't need to override this command as it doesn't exists in ember-cli. That also stands for get.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Includes design doc.