refactor (build): refactor the logic to set publicPath

[changLiuUNSW]

If we set deployUrl via the angular-cli.json, the ng serve will be affected as well because we set publicPath via appConfig.deployUrl in the webpack-build-common.ts

This PR can solve above issue and also remove duplicated logic deployUrl || appConfig.deployUrl; which already exists in build-webpack.ts

[filipesilva]

This fix also removes the functionality of using deployUrl via the config file though.

If that functionality is to be removed, then the code for it in the config needs to be removed as well.

[changLiuUNSW]

@filipesilva This fix will not remove functionality of using deployUrl via the config.
You can see below logic from build-webpack.ts

const deployUrl = runTaskOptions.deployUrl ||
                       CliConfig.fromProject().config.apps[0].deployUrl;

https://github.com/angular/angular-cli/blob/master/packages/angular-cli/tasks/build-webpack.ts#L17

We also have e2e test to cover the functionality of using deployUrl via the config here:
https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/deploy-url.ts#L9

The test passed with my change

[filipesilva]

Ok I understand now. I'm working on a big PR to refactor how these commands work though, so I'll try to introduce this logic there as well in case this doesn't get merged before.

[filipesilva]

Superseded by #4105

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}