Merged
Conversation
Contributor
|
lgtm but I'll defer to @hansl as he's been editing that file recently. |
Contributor
|
And thanks for fixing it @cexbrayat ! |
Contributor
|
Thanks @cexbrayat for the fix! Seems I missed that :) I'm rerunning the Windows tests. It's the only area where I'm not 100% sure symlink work. If the tests pass I'll merge. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the latest releases of angular-cli (up to 0.0.30), I've been running into an issue when the build is in a VM/docker container and using a shared file system with the host (
EPERM: operation not permittedfor BroccoliTypeScriptPlugin).After some research, it looks like it's not a new problem in the Broccoli/Ember-cli world, and that it is recommended to use
fs.symlinkSyncinstead offs.linkSync.See ember-cli/broccoli-caching-writer#2 for example and the related links.
It does appear to solve the problem, so here is a humble PR to (hopefully) fix it.