removed npm install step from upgrade process#4535
Closed
shairez wants to merge 1 commit intoangular:masterfrom
Closed
removed npm install step from upgrade process#4535shairez wants to merge 1 commit intoangular:masterfrom
shairez wants to merge 1 commit intoangular:masterfrom
Conversation
Because npm install is running as part of `ng update`. And also, if someone updates their package.json as part of `ng update`, one might wanna npm install only after that.
cacogr
reviewed
Feb 9, 2017
| ```bash | ||
| rm -rf node_modules dist # use rmdir on Windows | ||
| npm install --save-dev @angular/cli@latest | ||
| npm install |
There was a problem hiding this comment.
This was added in #2870 to address #2410 (comment), I don't know if it's still needed.
Contributor
|
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because npm install is running as part of
ng update.And also, if someone updates their package.json as part of
ng update, one might wanna npm install only after that.