chore(systemjs): load all dependencies via systemjs#481
Closed
filipesilva wants to merge 1 commit intoangular:masterfrom
Closed
chore(systemjs): load all dependencies via systemjs#481filipesilva wants to merge 1 commit intoangular:masterfrom
filipesilva wants to merge 1 commit intoangular:masterfrom
Conversation
This was referenced Apr 21, 2016
Closed
filipesilva
force-pushed
the
use-systemjs-for-all-deps
branch
7 times, most recently
from
27d16a2 to
4e5856f
Compare
filipesilva
force-pushed
the
use-systemjs-for-all-deps
branch
5 times, most recently
from
7d5a0f3 to
ea56444
Compare
filipesilva
force-pushed
the
use-systemjs-for-all-deps
branch
from
ea56444 to
d163506
Compare
Merged
|
anything holding this back? |
Contributor
Author
|
Closed in favor of #550. @NullVoxPopuli another PR with this content and more will be landing soon. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR loads all app dependencies via SystemJS instead of script tags. This is necessary for production builds so that these dependencies can be traced and built around.
It also adds
system-config.tsto thefilesentrytsconfig.jsonso that it doesn't have the 'not included in project' error.vendorNpmFileswere also fully moved intoangular-cli-buildto give more control over dependencies (for instance, allowing the user to not use the dev packages of angular 2).Closes #517
Closes #400