fix(@ngtools/webpack): continue past invalid imports#5028
Merged
hansl merged 5 commits intoangular:masterfrom Mar 1, 2017
Merged
fix(@ngtools/webpack): continue past invalid imports#5028hansl merged 5 commits intoangular:masterfrom
hansl merged 5 commits intoangular:masterfrom
Conversation
Contributor
Author
|
cc @hansl This should be quick |
hansl
approved these changes
Mar 1, 2017
Contributor
hansl
left a comment
There was a problem hiding this comment.
LGTM, but note that your example is faulty. If you have proper typings it will resolve correctly.
|
Your example is fault. How to can me using require('fs')? |
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to continue instead of bail.
This happens when for some reason Typescript cant locate a module in an import statement.
This WILL be necessary for supporting fs for platform-server
Example:
main.ts
To test, import this before your MainModule