feat(@angular/cli): add styles/scripts prefix#5844
Closed
avshenuk wants to merge 1 commit intoangular:masterfrom
Closed
feat(@angular/cli): add styles/scripts prefix#5844avshenuk wants to merge 1 commit intoangular:masterfrom
avshenuk wants to merge 1 commit intoangular:masterfrom
Conversation
Just for consideration. Add styles/scripts prefix in order to generate styles/scripts into different folders etc.
Contributor
|
What's the use case for this that you're trying to fix? |
Author
|
Currently all the generated files will go into the root. Having styles/scripts placed into their own folders is better from multiple perspectives where one of them is Security of the application. Following the principle: secure everything and ignore specific it would be inconvenient to ignore every generated style/script but instead a singe folder containing all these styles/scripts. Saturday, 08 April 2017, 01:16AM +03:00 from Hans notifications@github.com :
…What's the use case for this that you're trying to fix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub , or mute the thread .
|
Contributor
Contributor
|
Thank you for the work you put into this Pr, but I don't think this change provides enough benefit vs the risk. There's also some overlap with |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for consideration. Add styles/scripts prefix in order to generate styles/scripts into different folders etc.