fix(broccoli-typescript): properly parse compilerOptions#764
Merged
jeffbcross merged 1 commit intoangular:masterfrom May 13, 2016
Merged
fix(broccoli-typescript): properly parse compilerOptions#764jeffbcross merged 1 commit intoangular:masterfrom
jeffbcross merged 1 commit intoangular:masterfrom
Conversation
Previously, the settings in tsconfig would be ignored by the broccoli-typescript plugin, because the whole config's JSON was being provided to `convertCompilerOptionsFromJson()` instead of just the expected `compilerOptions`.
Contributor
|
Lgtm |
phillipgreenii
pushed a commit
to phillipgreenii/angular-cli
that referenced
this pull request
May 14, 2016
Previously, the settings in tsconfig would be ignored by the broccoli-typescript plugin, because the whole config's JSON was being provided to `convertCompilerOptionsFromJson()` instead of just the expected `compilerOptions`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the settings in tsconfig would be ignored by
the broccoli-typescript plugin, because the whole config's
JSON was being provided to
convertCompilerOptionsFromJson()instead of just the expected
compilerOptions.