Skip to content

Added support for non Administrator CLI user #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
degiorgig wants to merge 3 commits into from
Closed

Added support for non Administrator CLI user #905

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
473674c
Added support for non Administrator CLI user
degiorgig May 24, 2016
0f5cd44
Merge branch 'master' into patch-1
degiorgig May 27, 2016
b1cf6ac
Merge branch 'master' into patch-1
degiorgig May 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/broccoli/broccoli-typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@ class BroccoliTypeScriptCompiler extends Plugin {
this._fileRegistry[tsFilePath].outputs.forEach(absoluteFilePath => {
const outputFilePath = absoluteFilePath.replace(this.cachePath, this.outputPath);
fse.mkdirsSync(path.dirname(outputFilePath));
fs.symlinkSync(absoluteFilePath, outputFilePath);
try {
fs.symlinkSync(absoluteFilePath, outputFilePath);
} catch (e) {
const conentStr = fs.readFileSync(absoluteFilePath);
Copy link

@mernen mernen Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be contentStr?

Copy link
Contributor

@filipesilva filipesilva Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will fix it in another PR.

Copy link
Contributor

@filipesilva filipesilva Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #981

fs.writeFileSync(outputFilePath, conentStr);
}
});
} else {
this._fileRegistry[tsFilePath].version = entry.mtime;
Expand Down Expand Up @@ -203,7 +208,12 @@ class BroccoliTypeScriptCompiler extends Plugin {
fs.writeFileSync(absoluteFilePath, content, FS_OPTS);

fse.mkdirsSync(path.dirname(outputFilePath));
fs.symlinkSync(absoluteFilePath, outputFilePath);
try {
fs.symlinkSync(absoluteFilePath, outputFilePath);
} catch (e) {
const conentStr = fs.readFileSync(absoluteFilePath);
fs.writeFileSync(outputFilePath, conentStr);
}
}

_addNewFileEntry(entry, checkDuplicates /* = true */) {
Expand Down