fix(deploy): Fix base href for user pages#965
Merged
filipesilva merged 2 commits intoangular:masterfrom Jun 1, 2016
rockwotj:master
Merged
fix(deploy): Fix base href for user pages#965filipesilva merged 2 commits intoangular:masterfrom rockwotj:master
filipesilva merged 2 commits intoangular:masterfrom
rockwotj:master
Conversation
Deploying to user pages would change the base URL to something like "/angular.github.io/" instead of the correct "/" due to the URL structure for user pages.
Contributor
Author
|
Any idea why the build is failing on |
Contributor
|
@rockwotj the fail must be a fluke, I'll restart it. Thanks for making this PR btw! |
Contributor
|
@rockwotj the CI is showing a lint error, can you fix it? |
Contributor
Author
|
@filipesilva it passes now! |
devCrossNet
pushed a commit
to devCrossNet/universal-cli
that referenced
this pull request
Jun 9, 2016
* fix(deploy): Fix base href for user pages Deploying to user pages would change the base URL to something like "/angular.github.io/" instead of the correct "/" due to the URL structure for user pages. * style(lint): use single quotes for string
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying to user pages would change the base URL to something like "/angular.github.io/" instead of the correct "/" due to the URL structure for user pages.