Skip to content

build(aio): fail the doc-gen if there is an invalid {@link ...} tag#16680

Merged
petebacondarwin merged 1 commit intoangular:masterfrom
petebacondarwin:aio-bad-links
May 10, 2017
Merged

build(aio): fail the doc-gen if there is an invalid {@link ...} tag#16680
petebacondarwin merged 1 commit intoangular:masterfrom
petebacondarwin:aio-bad-links

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented May 10, 2017 •
edited
Loading

This fail behaviour is only turned on for yarn docs;
in yarn docs-watch you only receive a warning.
This is because you can get false errors when watching
since we don't parse all the docs in that case.

Closes #15199

@petebacondarwin
build(aio): fail the doc-gen if there is an invalid {@link ...} tag
bd374f9 
This fail behaviour is only turned on for `yarn docs`;
in `yarn docs-watch` you only receive a warning.
This is because you can get false errors when watching
since we don't parse all the docs in that case.
@petebacondarwin petebacondarwin added comp: aio area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer labels May 10, 2017
@petebacondarwin petebacondarwin mentioned this pull request May 10, 2017
Closed
3 tasks
@mary-poppins
Copy link

mary-poppins commented May 10, 2017

The angular.io preview for bd374f9 is available here.

gkalpak
gkalpak approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@petebacondarwin petebacondarwin merged commit f5335d1 into angular:master May 10, 2017
@petebacondarwin petebacondarwin deleted the aio-bad-links branch May 10, 2017 10:40
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aio: yarn docs prints warnings and errors but exists with exit code 0

4 participants

@petebacondarwin @mary-poppins @gkalpak @googlebot