fix(bazel): ng test should run specific ts_web_test_suite#30526
fix(bazel): ng test should run specific ts_web_test_suite#30526kyliau wants to merge 1 commit intoangular:masterfrom
Conversation
There was a problem hiding this comment.
I would just add in the commit message why the change is needed and that it assumes that the BUILD files are the ones generated by ng new.
The downside of this is that if you leave BUILD files on disk and add more tests than ng test will no longer run all tests which may be unexpected. Maybe Alex's suggestion to mark rollup_bundle as "manual" would be better?
|
This LGTM but I'll let @alexeagle & @gregmagolan give the final approval. |
|
I agree with @gregmagolan that users may get confused over the behavior when they start to customize the build, but they'll have to understand which targets to run when they do that. This would be a good fix for 8 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR closes #30191
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information