feat(testing): use zones to avoid the need for injectAsync

[juliemr]

Use a zone counting timeouts and microtasks to determine when a test
is finished, instead of requiring the test writer to use
injectAsync and return a promise.

See #5322

[juliemr]

cc @vicb @IgorMinar

Zones seem to work smoothly and remove complexity for the user for the async tests. All tests which use inject are now being run asynchronously, which as we discussed before adds a very small (couple ms) penalty time to each test. I like this overall - thoughts?

[juliemr]

Note that this isn't actually a breaking change, because both inject and injectAsync do the same thing now and the return value doesn't matter. A cleanup would remove injectAsync entirely.

[0x-r4bbit]

This is awesome Julie!

On Thu, Nov 19, 2015, 3:52 AM Julie Ralph notifications@github.com wrote:

Note that this isn't actually a breaking change, because both inject and
injectAsync do the same thing now and the return value doesn't matter. A
cleanup would remove injectAsync entirely.

—
Reply to this email directly or view it on GitHub
#5375 (comment).

[vicb]

<Zone>global.zone

[juliemr]

Good catch, done.

[vicb]

typo: asynchronous

[vicb]

A few minor comments, otherwise LGTM.
Great PR !

[IgorMinar]

@wardbell fyi - this will affect testing docs

[IgorMinar]

looks great! Please deprecate injectAsync and add docs about the async behavior for inject

[IgorMinar]

OMG, I just realized that this might mean that we don't need to refactor all of our tests in angular2/angular2 to return promises. Now I'm really stoked.

Do we properly detect errors and surface them or will we still see jasmine timeouts when an error occurs in an async test?

[juliemr]

Errors should be properly output: As in this test:

    it('should fail when an asynchronous error is thrown', (done) => {
      var itPromise = patchJasmineIt();

      it('throws an async error',
         inject([], () => { setTimeout(() => { throw new Error('bar'); }, 0); }));

      itPromise.then(() => { done.fail('Expected function to throw, but it did not'); }, (err) => {
        expect(err.message).toEqual('bar'); // <-- bar not just timeout!
        done();
      });
      restoreJasmineIt();
    });

[wardbell]

Big win! Looking forward to trying this.

[juliemr]

Deprecation notice and docs are done.

[vsavkin]

Could you rebase?

[juliemr]

@vsavkin done!

[IgorMinar]

let's get this in! :)

[vsavkin]

Merged via 0c9596a

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}