Skip to content

refactor(dart/transform): Remove reflectPropertiesAsAttributes#5512

Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:deprecated_option
Closed

refactor(dart/transform): Remove reflectPropertiesAsAttributes#5512
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:deprecated_option

Conversation

@kegluneq
Copy link

Remove deprecated reflectPropertiesAsAttributes as an option. It has
been renamed reflect_properties_as_attributes.

Closes #5108

Remove deprecated `reflectPropertiesAsAttributes` as an option. It has
been renamed `reflect_properties_as_attributes`.

Closes angular#5108
@kegluneq kegluneq added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2015
@vsavkin vsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2015
@vsavkin vsavkin assigned kegluneq and unassigned vsavkin Nov 30, 2015
@kegluneq kegluneq added action: merge The PR is ready for merge by the caretaker refactoring Issue that involves refactoring or code-cleanup and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 30, 2015
@naomiblack naomiblack modified the milestone: beta-00 Nov 30, 2015
@kegluneq kegluneq assigned vsavkin and unassigned kegluneq Dec 1, 2015
@mary-poppins
Copy link

Merging PR #5512 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5512.

@kegluneq kegluneq closed this in 2ada3ec Dec 1, 2015
@kegluneq kegluneq deleted the deprecated_option branch December 3, 2015 20:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After 30 Nov, remove reflectPropertiesAsAttributes from common/options.dart and common/options_reader.dart.

5 participants