refactor(@angular/platform-browser-dynamic): relocate DOMTestComponentRenderer to @angular/platform-browser
#60453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
…r` to `@angular/platform-browser` This commit moves `DOMTestComponentRenderer` to `@angular/platform-browser/testing`, allowing the Angular CLI to eliminate its dependency on `@angular/platform-browser-dynamic`, which would no longer be required for new projects.
alan-agius4
force-pushed
the
platform-browser-dynamic
branch
from
1e566ff to
b8853bd
Compare
alan-agius4
added
the
action: review
devversion
approved these changes
Mar 19, 2025
…Renderer` to `@angular/platform-browser`
AndrewKushnir
approved these changes
Mar 19, 2025
AndrewKushnir
approved these changes
Mar 19, 2025
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
devversion
approved these changes
Mar 19, 2025
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
alan-agius4
added
action: merge
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Mar 19, 2025
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects. This is now possible due to angular/angular#60453
…Renderer` to `@angular/platform-browser`
Member
|
This PR was merged into the repository by commit 5753aa7. The changes were merged into the following branches: main, 19.2.x |
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Mar 20, 2025
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects. This is now possible due to angular/angular#60453
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Mar 20, 2025
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects. This is now possible due to angular/angular#60453
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves
DOMTestComponentRendererto@angular/platform-browser/testing, allowing the Angular CLI to eliminate its dependency on@angular/platform-browser-dynamic, which would no longer be required for new projects.