Skip to content

fix(transformer): record HostBinding annotations applied to getters#6283

Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:fix_transformer_host_binding_annotation
Closed

fix(transformer): record HostBinding annotations applied to getters#6283
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:fix_transformer_host_binding_annotation

Conversation

@vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Jan 6, 2016

Closes #4407

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 6, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add && node.isGetter (& test)

@vicb vicb added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 6, 2016
@vsavkin vsavkin force-pushed the fix_transformer_host_binding_annotation branch from 9bcbebe to d43b55e Compare January 6, 2016 02:57
@vsavkin vsavkin removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 6, 2016
@vsavkin vsavkin assigned vsavkin and unassigned vicb Jan 6, 2016
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Jan 6, 2016
@IgorMinar
Copy link
Contributor

@jeffbcross any reason why this hasn't been merged yet?

// @rkirov

@mary-poppins
Copy link

Merging PR #6283 on behalf of @rkirov to branch presubmit-rkirov-pr-6283.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dart] Transformers handling of Input, Output, HostBinding and HostListener

6 participants