Inherit doc return type from class#2640
Merged
jamesdaniels merged 2 commits intoangular:masterfrom Nov 11, 2020
P1X3:doc-return-type-fix
Merged
Inherit doc return type from class#2640jamesdaniels merged 2 commits intoangular:masterfrom P1X3:doc-return-type-fix
jamesdaniels merged 2 commits intoangular:masterfrom
P1X3:doc-return-type-fix
Conversation
Contributor
Author
|
Browsing deeper into other PR I noticed that this PR will will conflict with #2573 |
Member
|
Thanks, appreciate this. Aiming to start prepping for the 6.1 release shortly and will take a look at these PRs. |
jamesdaniels
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? noDescription
Updated doc function generic return type to inherit type from class generic
Code sample
Without this change defining type on
collectionfunction call does not pass it todocfunction call:db.collection<Location>('locations').doc('someid').valueChanges(); // Returns Observable<unknown>db.collection<Location>('locations').doc<Location>('someid').valueChanges(); // Returns Observable<Location>With this PR calling
collectionfunction with type will pass it todocfunction call.db.collection<Location>('locations').doc('someid').valueChanges(); // Returns Observable<Location>db.collection<Location>('locations').doc<Location>('someid').valueChanges(); // Returns Observable<Location>