fix(deploy): remove direct workspace access#2643
Merged
jamesdaniels merged 1 commit intoangular:masterfrom Nov 11, 2020
Merged
Conversation
Depending on the configuration and initialization of the builder runtime, there may not be a workspace file or the raw values within the workspace file may not represent the final values used by a builder. To support cases where inspection of builder target options is needed, the builder runtime provides a utility function (`getTargetOptions`) within the context object passed to each builder. This utility function is now used within the deploy builder to access builder target options. Also, as a result of these changes, usage of the experimental workspace API was removed. This experimental API is no longer present as of Angular v11.
clydin
force-pushed
the
deploy-remove-direct-workspace
branch
from
f19f386 to
ca2c3e9
Compare
This was referenced Nov 10, 2020
Member
|
Thanks for this @clydin, do you think it's reasonable to try to have NG 9, 10 & 11 compatibility or should we bump our peer dep and cut a major ourselves? |
Member
Author
|
These changes should be fine on all three so the minimum could technically stay within the scope of deploy. |
Member
|
Cool. Yeah we're good on compatibility across those majors in the library code, I'm planning a break coming up anyway as modular rewrite of the Firebase JS SDK is inbound. I'll merge these and add NG 11 peer in a minor for tomorrow. Thanks again. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the configuration and initialization of the builder runtime, there may not be a workspace file or the raw values within the workspace file may not represent the final values used by a builder. To support cases where inspection of builder target options is needed, the builder runtime provides a utility function (
getTargetOptions) within the context object passed to each builder. This utility function is now used within the deploy builder to access builder target options. Also, as a result of these changes, usage of the experimental workspace API was removed. This experimental API is no longer present as of Angular v11.