fix(core): fix the instance cache logic, closes #2666#2667
Merged
jamesdaniels merged 1 commit intomasterfrom Nov 18, 2020
Merged
fix(core): fix the instance cache logic, closes #2666#2667jamesdaniels merged 1 commit intomasterfrom
jamesdaniels merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that in lazy-loads and other sufficiently complex use-cases (e.g, not my sample app) ngc / webpack has now (6.1) decided that our injectables (such as AngularFirestore) can be duplicated.
While I was aware this could happen (lazy-loads for instance) and intended my instance cache to cover this and the HMR use-case, I had a bug in my fetch logic which would try to reinitialize the SDK instance even when the settings hadn't changed. Whoops. Explains why this wasn't working for HMR users as intended either.