Skip to content

fix(storage): unsubscribing from the upload progress will not cancel …#2688

Merged
jamesdaniels merged 1 commit intomasterfrom
fix_upload_cancelation
Nov 24, 2020
Merged

fix(storage): unsubscribing from the upload progress will not cancel …#2688
jamesdaniels merged 1 commit intomasterfrom
fix_upload_cancelation

Conversation

@jamesdaniels
Copy link
Member

  • unsubscribing from upload progress shouldn't cancel the upload, that was undefined behavior IMO
  • shareReplay the upload, so one could pick back up (say if they had upload progress | async on a view somewhere)

Closes #2685

@jamesdaniels jamesdaniels merged commit d845cdd into master Nov 24, 2020
@jamesdaniels jamesdaniels deleted the fix_upload_cancelation branch November 24, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

don't cancel the upload if you unsubscribe from AngularFireUploadTask.percentageChanges()

2 participants