fix: auth settings setter instead of ovewriting readonly object#2833
Merged
jamesdaniels merged 2 commits intoangular:masterfrom May 18, 2021
Merged
fix: auth settings setter instead of ovewriting readonly object#2833jamesdaniels merged 2 commits intoangular:masterfrom
jamesdaniels merged 2 commits intoangular:masterfrom
Conversation
jamesdaniels
requested changes
May 17, 2021
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix. See nit
jamesdaniels
approved these changes
May 18, 2021
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM, prepping the next release this evening. Will include.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
Instead of assigning to the auth
settingsreadonly object, assign directly the propertyappVerificationDisabledForTesting.