This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Temporary fix for conflicting traceurRuntime versions in benchpress lib and consumer code #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a brute-force solution to unblock writing benchmarks that require a different version of $traceurRuntime.
The benchpress build step rewrites all instances of $traceurRuntime to $diTraceurRuntime and all instances of System to DITraceurSystem. Note, this only rewrites code that gets compiled into bp.js or auto-bp.js
As part of the effort of removing the build step in #18, a better solution to DI that does not require the traceur runtime to be bundled should be explored.
Fixes #21