Skip to content

docs(select): update live examples to use labels #15095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Feb 20, 2019
Merged

docs(select): update live examples to use labels #15095

jelbourn merged 1 commit into from
Feb 20, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 5, 2019

  • Fixes a few examples that didn't have labels for the native select.
  • Switches all of the examples to use the mat-label, instead of a placeholder.

Fixes #15022.

@crisbeto
docs(select): update live examples to use labels
8686902 
* Fixes a few examples that didn't have labels for the native select.
* Switches all of the examples to use the `mat-label`, instead of a `placeholder`.

Fixes angular#15022.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 5, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner February 5, 2019 22:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 5, 2019
jelbourn
jelbourn approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker labels Feb 20, 2019
@jelbourn jelbourn merged commit 4021929 into angular:master Feb 20, 2019
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
@crisbeto @jelbourn
docs(select): update live examples to use labels (#15095)
eae0efa 
* Fixes a few examples that didn't have labels for the native select.
* Switches all of the examples to use the `mat-label`, instead of a `placeholder`.

Fixes #15022.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Native select examples are missing programatic labels

3 participants

@crisbeto @jelbourn @googlebot