Skip to content

Button icons aria labels changes #14998 #15112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 3 commits into from
Feb 11, 2019
Merged

Button icons aria labels changes #14998 #15112

jelbourn merged 3 commits into from
Feb 11, 2019

Conversation

@Suresh918
Copy link
Contributor

@Suresh918 Suresh918 commented Feb 7, 2019 •
edited
Loading

Fixes #14998

@Suresh918 Suresh918 requested a review from jelbourn as a code owner February 7, 2019 14:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2019
@Suresh918
Copy link
Contributor Author

Suresh918 commented Feb 7, 2019

Hi jelbourn, As per documentation area label is hidden for icon as it does not convey any useful information alone. That's I added aria label to the button even though we can enable area label for icon using aria-hidden="false". Let me know if you want me to use aria-hidden="false" instead of button area label.

crisbeto
crisbeto approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add a note to the commit message that says "Fixes #14998"? Otherwise the issue won't be closed when the PR is merged.

@crisbeto crisbeto added pr: lgtm target: patch This PR is targeted for the next patch release labels Feb 7, 2019
jelbourn
jelbourn approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed pr: merge safe labels Feb 7, 2019
@jelbourn jelbourn merged commit 123976f into angular:master Feb 11, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Button examples that contain only a mat-icon are missing an accessible name

4 participants

@Suresh918 @jelbourn @crisbeto @googlebot