Skip to content

fix(bottom-sheet): focus trap not being attached when autoFocus is disabled #15125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Feb 12, 2019
Merged

fix(bottom-sheet): focus trap not being attached when autoFocus is disabled #15125

jelbourn merged 1 commit into from
Feb 12, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 8, 2019

Fixes the bottom sheet container not creating a focus trap, if autoFocus is set to false.

Fixes #15119.

@crisbeto
fix(bottom-sheet): focus trap not being attached when autoFocus is di…
26a6ca7 
…sabled

Fixes the bottom sheet container not creating a focus trap, if `autoFocus` is set to `false`.

Fixes angular#15119.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Feb 8, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner February 8, 2019 11:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 8, 2019
@jelbourn jelbourn merged commit 3787695 into angular:master Feb 12, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bottom-sheet: focus trapping does not work unless autoFocus is true

4 participants

@crisbeto @mmalerba @jelbourn @googlebot