feat(a11y): add injection token configure default politeness and duration #15126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
changed the title
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15121/live-announcer-defaults
branch
from
5ed7cc2 to
8612eb8
Compare
devversion
approved these changes
Feb 8, 2019
| @Inject(DOCUMENT) _document: any) { | ||
| @Inject(DOCUMENT) _document: any, | ||
| @Optional() @Inject(LIVE_ANNOUNCER_DEFAULT_OPTIONS) | ||
| private _defaultOptions?: LiveAnnouncerDefaultOptions) { |
Member
Author
There was a problem hiding this comment.
It's intentional. I had to wrap the line so it doesn't go over the limit.
Member
There was a problem hiding this comment.
Yeah the wrapping makes sense. Though the additional spaces are inconsistent with what we usually do (and I've not found similar wrapping in the repo). Not trying to be too nitpicky, but this is an easy fix to be consistent.. 😄
e.g. see drag.ts
jelbourn
approved these changes
Feb 8, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM aside from Paul's comment
…tion Adds an injection token that allows consumers to configure the default `politeness` and `duration` for the live announcer. Fixes angular#15121.
crisbeto
force-pushed
the
15121/live-announcer-defaults
branch
from
8612eb8 to
c064bfd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an injection token that allows consumers to configure the default
politenessanddurationfor the live announcer.Fixes #15121.