Skip to content

fix:(tabs) add call for rechecking tab scroll distance #15173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lau32 wants to merge 2 commits into from
Closed

fix:(tabs) add call for rechecking tab scroll distance #15173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a97b6c2
fix:(tabs) add call for rechecking tab scroll distance
lau32 Feb 13, 2019
6aeeea8
Merge branch 'master' of https://github.com/angular/material2 into #1…
lau32 Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/lib/tabs/tab-header.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,26 @@ describe('MatTabHeader', () => {
expect(tabHeaderElement.classList).toContain(enabledClass);
});

it('scroll to last tab', () => {
Copy link
Member

@crisbeto crisbeto Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we usually start test names with "should".

fixture = TestBed.createComponent(SimpleTabHeaderApp);
appComponent = fixture.componentInstance;
appComponent.tabs = [
{label: 'tab one'},
{label: 'tab two'},
{label: 'tab three'},
{label: 'tab four'},
{label: 'tab five'},
{label: 'tab six'},
{label: 'tab seven'},
{label: 'tab eight'},
];
appComponent.tabHeader.selectedIndex = 8;
Copy link
Member

@crisbeto crisbeto Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 7? Index 8 is out of bounds of the array.


fixture.componentRef.changeDetectorRef.markForCheck();

expect(appComponent.tabHeader.scrollDistance)
Copy link
Member

@crisbeto crisbeto Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this test is verifying the correct thing. I tried pasting it into master without the fix from this PR and it still passes. This somewhat defeats the purpose of the test, because we won't know if we accidentally introduce a regression.

.toBe(appComponent.tabHeader._getMaxScrollDistance());
});
});
});

Expand Down
1 change: 1 addition & 0 deletions src/lib/tabs/tab-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export class MatTabHeader extends _MatTabHeaderMixinBase
const dirChange = this._dir ? this._dir.change : observableOf(null);
const resize = this._viewportRuler.change(150);
const realign = () => {
this._scrollToLabel(this._selectedIndex);
this.updatePagination();
this._alignInkBarToSelectedTab();
};
Expand Down