Skip to content

fix(list): override native button text align in action list #15404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josephperrott merged 1 commit into from
Mar 8, 2019
Merged

fix(list): override native button text align in action list #15404

josephperrott merged 1 commit into from
Mar 8, 2019

Conversation

@mitchellwills
Copy link
Contributor

@mitchellwills mitchellwills commented Mar 6, 2019 •
edited
Loading

This happens to work when the content is just text; however, content gets center
aligned when there are matLine elements nested in a <button mat-list-item>.

@mitchellwills
fix(list): override native button text align in action list
ddd9218 
This happens to work when the content is just text; however, content gets center
aligned when there are matLine elements nested in a <button mat-list-item>.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 6, 2019
jelbourn
jelbourn approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 6, 2019
@josephperrott josephperrott merged commit ddeeb18 into angular:master Mar 8, 2019
josephperrott pushed a commit that referenced this pull request Mar 8, 2019
@mitchellwills @josephperrott
fix(list): override native button text align in action list (#15404)
aaec2d5 
This happens to work when the content is just text; however, content gets center
aligned when there are matLine elements nested in a <button mat-list-item>.
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@mitchellwills
fix(list): override native button text align in action list (angular#…
705211b 
…15404)

This happens to work when the content is just text; however, content gets center
aligned when there are matLine elements nested in a <button mat-list-item>.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mitchellwills @jelbourn @googlebot @josephperrott